feat(log)!: support multiple loggers #1595

innocenzi · 2025-10-02T19:46:07Z

This pull request dissociates tempest/debug from tempest/log, among other improvements.

Logger now support tagged configurations
All log files default to being in .tempest/logs instead of ./log
The debug package has its own config for defining the debug log file
Debug tailing is now more readable
Channel properties are now properly commented
Channels support minimum log levels
The single tail command and the tail:project one have been removed, there's just tail:debug and tail:logs now

This is still a draft because I feel like there could be better APIs for the config, but not sure what exactly. The issue right now is that if you don't know about the existing channel classes, you have to look up the docs, because the channels property is an array.

~~Maybe I'm overthinking and it's fine as-is? Currently, it looks like that:~~

return new LogConfig(
    channels: [
        new DailyLogChannel(
            path: internal_storage_path('logs', 'tempest.log'),
            maxFiles: env('LOG_MAX_FILES', default: 31),
            prefix:env('APPLICATION_NAME', default: 'tempest'),
        ),
    ],
);

EDIT: ended up using the same pattern as everywhere in Tempest—dedicated config files, with one config allowing for multiple channels.

return new DailyLogConfig(
    path: internal_storage_path('logs', 'tempest.log'),
    prefix: env('APPLICATION_NAME', default: 'tempest'),
    maxFiles: env('LOG_MAX_FILES', default: 31),
);

Due to this change, this PR unfortunately becomes breaking.

As a reminder, to log differently in different environment, we can have logging.<env>.config.php files.

TODO:

Update documentation

brendt · 2025-10-03T12:33:35Z

Looks clean!

How will we handle the breaking change? Is there a way we can keep the old way for now but deprecate it? Just so that we can have this in 2.x already and don't have to wait until 3.x

innocenzi · 2025-10-03T12:57:06Z

There would be naming conflicts with the new LogConfig interface unfortunately. That would be a log of glue code too...

To be honest, the breaking change is minor: if users have a custom logging config, it will be ignored in favor of the default one

EDIT: actually, it won't be ignored, it will crash because they'd be instantiating an interface

brendt · 2025-10-04T16:16:23Z

I'm fine merging it in; but we should provide a rector for it then. Are you up for that? Otherwise I'll take care of it

innocenzi · 2025-10-04T23:26:16Z

I updated the PR to bring some other improvements, notably tagged configurations, in order to have the ability to have multiple loggers for different purposes, which is actually quite important!

I also added docs to the PR, so it's ready to be merged.

@brendt, I tried making a Rector rule for the breaking change, but couldn't manage, so if you still want to, you can do it 😓

github-actions · 2025-11-04T02:08:55Z

This pull request is stale because it has been open for 30 days with no activity.

innocenzi · 2025-11-10T20:28:51Z

@brendt can we merge?

brendt · 2025-11-14T07:28:56Z

I'm on the fence about it if we don't have a rector for it. Gonna ask around on Discord for some real life examples.

aazsamir · 2025-11-14T08:44:32Z

./tempest tail:debug causes my CPU temperature to rise by 15 degrees 😄 Maybe it's busy waiting? I'm using linux

btw. related XKCD https://xkcd.com/1172/

brendt · 2025-11-14T10:08:12Z

causes my CPU temperature to rise by 15 degrees

Do you mean with this branch?

aazsamir · 2025-11-14T10:14:32Z

causes my CPU temperature to rise by 15 degrees

Do you mean with this branch?

Yes, but now I checked and it's the same on main, so not a regression, sorry^^

brendt · 2025-11-22T05:52:34Z

Gonna ask around on Discord for some real life examples

I believe many people indeed are using custom logging config. I would only be comfortable merging this in 2.x if we have an automated upgrade for it. I'm not sure that'll be trivial to do though 😬

I briefly looked into it, and I'm not sure we can do what we need to do with Rector to automate this upgrade. That being said, maybe my Rector knowledge is lacking.

Maybe we should simply start preparing for 3.0 and include this one in there?

innocenzi · 2025-11-23T23:31:09Z

Personally I would say the Tempest community is small enough for us to be able to make that breaking change on a minor version 😬

That being said given your question on the Discord server I would say that few are actually customizing it

If you really don't want the breaking change though, we can create a 3.x and merge this

brendt · 2025-11-28T07:02:22Z

I've given it some more thought and I think I'd like it to be targeted toward 3.x.

I'm ok tagging 3.x soon though. Let's aim for the beginning of January? That way I can finish my FrankenPHP PR, and then we'll merge 8.5 support in 3.x as well

brendt · 2025-12-03T12:49:19Z

@innocenzi feel free to merge in 3.x when you're ready

)

…expiration (#1758)

…es (#1782)

…lculation (#1770)

innocenzi changed the title ~~refactor(logging)!: dissociate tempest/debug from tempest/log~~ refactor(logging): dissociate tempest/debug from tempest/log Oct 2, 2025

innocenzi force-pushed the feat/logging-improvements branch from 9a1bb51 to 0757d78 Compare October 2, 2025 19:52

innocenzi changed the title ~~refactor(logging): dissociate tempest/debug from tempest/log~~ refactor(logging)!: dissociate tempest/debug from tempest/log Oct 2, 2025

innocenzi force-pushed the feat/logging-improvements branch from 67d17c2 to 55e95fd Compare October 2, 2025 22:53

innocenzi marked this pull request as ready for review October 3, 2025 12:17

innocenzi requested a review from brendt October 3, 2025 12:17

innocenzi changed the title ~~refactor(logging)!: dissociate tempest/debug from tempest/log~~ feat(log)!: support multiple loggers Oct 4, 2025

github-actions bot added the Stale This issue has seen no activity for a while label Nov 4, 2025

innocenzi removed the Stale This issue has seen no activity for a while label Nov 4, 2025

brendt changed the base branch from main to 3.0 November 28, 2025 07:02

brendt added the 3.x label Nov 28, 2025

xHeaven added 5 commits December 3, 2025 13:51

fix(core): gracefully handle missing seeders when using db:seed (#1759

450ca75

)

fix(auth): pass scopes/options to auth URL builder (#1750)

cbe54d7

fix(auth): update outdated authenticatable import (#1752)

5c68b96

refactor(auth): remove double base url call (#1753)

96dad91

feat(cache): make assertLocked ensure that the checked lock has an …

1a2e8fb

…expiration (#1758)

xHeaven and others added 26 commits December 3, 2025 23:00

refactor(auth): clear oauth state after validation (#1754)

c5db557

refactor(debug): correct dd() return type and simplify conditionals (…

ee94b81

…#1766)

refactor(database): minor cleanup (#1768)

4cb006c

refactor(datetime): fix return type annotation and parameter order (#…

95dcb32

…1767)

refactor(log): fix parameter types (#1771)

9ac7b95

refactor(mail): correct SMTP defaults and config handling (#1772)

f53b221

fix(process): properly return exit code if missing (#1776)

9ad1587

refactor(mapper): improve property and enum handling (#1773)

05165bd

refactor(support): add validation and fix edge cases in array helpers (…

dc701e3

…#1779)

refactor(validation): add type guards and Unicode support across rules (

567245f

#1780)

refactor(vite-plugin): fix redirect handling and improve error messag…

288ac6e

…es (#1782)

refactor(core): simplify view component resolution (#1783)

fdd6b8b

refactor(kv-store): fix typo, correct type annotation, and fix TTL ca…

c7237dc

…lculation (#1770)

refactor(icon): minor improvements (#1769)

fcf35f2

feat(container): make all container properties publicly readable (#1785)

be93ec1

chore: release v2.13.0

6153ffe

chore: post-release clean up

f9c246d

refactor(logging)!: dissociate tempest/debug from tempest/log

e8660ae

refactor: simply configuration

8cf238a

refactor: revert custom datetime changes

ce89985

refactor: use environment as logging prefix

809538f

feat: log exceptions

b80cf72

refactor: clean up and docs

8d1ec02

style: apply fixes from mago

ca8c4b1

fix: remove unused appconfig assignation

b633707

style: apply fixes from mago

7a9ff42

innocenzi force-pushed the feat/logging-improvements branch from f2d32fb to 7a9ff42 Compare December 7, 2025 14:45

innocenzi deleted the branch 3.0 December 7, 2025 14:50

innocenzi closed this Dec 7, 2025

innocenzi mentioned this pull request Dec 7, 2025

feat(log)!: support multiple loggers #1788

Merged

Uh oh!

feat(log)!: support multiple loggers #1595

feat(log)!: support multiple loggers #1595

Uh oh!

Conversation

innocenzi commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendt commented Oct 3, 2025

Uh oh!

innocenzi commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendt commented Oct 4, 2025

Uh oh!

innocenzi commented Oct 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

innocenzi commented Nov 10, 2025

Uh oh!

brendt commented Nov 14, 2025

Uh oh!

aazsamir commented Nov 14, 2025

Uh oh!

brendt commented Nov 14, 2025

Uh oh!

aazsamir commented Nov 14, 2025

Uh oh!

brendt commented Nov 22, 2025

Uh oh!

innocenzi commented Nov 23, 2025

Uh oh!

brendt commented Nov 28, 2025

Uh oh!

brendt commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

innocenzi commented Oct 2, 2025 •

edited

Loading

innocenzi commented Oct 3, 2025 •

edited

Loading